Convert achievements content in a object like "links"
Closed this issue · 5 comments
reinhapa commented
I would suggest to convert the existing json structure part of the achievements to a similar way as the links section:
From now:
"achievements": [
"Achievement without link",
"<a href='http:/somehost.somedomain'>Awesome work</a>"
]
To something like this:
"achievements": [
{
"title": "Achievement without link"
},
{
"title": "Awesome work",
"url": "http:/somehost.somedomain/"
}
]
madmas commented
Hi, that idea looks really good to me.
It would require to change the angular code and the json file (probably doable with a structural search/replace aka regexp, i think ;))
do you want to do a PR for this or work on one of the next hackergartens on it? :)
reinhapa commented
Is there any Problem with my PR so far? I just did not see any comments so far...
madmas commented
Woha, I'm very sorry, it slipped through. I'll lokk at it first thing at the hackergarten tonight, thanks a lot!