Fix Filter modal's date range buttons style not being applied

Question

Fix Filter modal's date range buttons style not being applied

Closed this issue 2 months ago · 7 comments

Overview

We need to apply styling on the pre-defined date range buttons in the Filters modal, to have the Last Week, Last Month, Last 3 Months buttons styled.

Action Items

Refer to error popup at: components/DateSelector/DateSelector.jsx , line - 14.
- Fix import error to apply the styles defined in iconStyle obj:
  components/DateSelector/DateSelector.jsx , line - 26.

Resources/Instructions

[Replace this text - Provide these resources here if exist. Provide screenshot only if the issue has visual
changes on the site, do not post screenshots of codebase]

Figma design file link: https://www.figma.com/design/eF63O8yIGz2soQ4JJFfyoK/311_Data_UXUI?node-id=4081-9245&t=dREizYCRxn9JzUaR-1
Related previous ticket: n/a

Screenshot before proposed changes

Screenshot after proposed changes

Answer 1 · 2024-09-26T03:51:02.000Z

@traycn this is looking good. When you're ready, remove draft and add ready for prioritization.

Answer 2 · 2024-09-26T03:51:33.000Z

My edits to the page: added link to the Figma page. Also adding Milestone.

Answer 3 · 2024-09-26T23:06:05.000Z

Prioritized and ready to be picked up!

Answer 4 · 2024-10-01T20:12:17.000Z

PR has been made: #1838

Answer 5 · 2024-10-02T21:07:15.000Z

@traycn I'm going to OK this to get approved. This is a new idea, but I feel like 1pt Size and under probably can just use 1 review. This should alleviate both of us needing to watch every single PR moving through.

Answer 6 · 2024-10-03T00:50:31.000Z

I will wait til @traycn gives the ok before merging.

Answer 7 · 2024-10-03T01:02:56.000Z

Approved! Moving the styles to the seperate file was a great change. Taking note that we are referencing styles for the DateSelector dropdown at: components/DateSelector/useStyles.js

Feel free to merge @Brandoncyu