Bugfix: Searching an address outside of an NC boundary silently fails
Closed this issue · 7 comments
Overview
We need to fix a regression so that users can still look up addresses outside of NC boundaries.
Action Items
- Modify behavior of the else block on L663 of Map.jsx
- if
ncIdOfAddressSearchis empty, still attempt to set the address state so that a geocoder pin is placed
- if
Dev Resources
Useful Files and Components
- MapSearch.jsx (see props)
- Map.jsx (see L534,
onGeocoderResult(result)
Mapbox Docs
Resources/Instructions
- Bug Hunt report: #1726 (comment)
Screen recording after proposed changes
[insert screenshot here]
I'm opening this up as ready to work on. Smaller than 1pt, skipping dev lead review.
ETA Oct Oct 17 Thursday
@ryanfchase
I need a bit of clarification.
I was able to have the marker placed, but did we want it to zoom in on the location?
If we want that to still occur I'll have to look into it deeper since I believe the zoom is based on the neighborhood council.
Adding this as a point of discussion for today's agenda. I'll add a response soon:
Design team to discuss in breakouts this evening. Follow up coming after meeting is over.
@bphan002 for now, when an address is provided outside of an NC, can we fly to that address with a zoom level of 9? Design will be working on a ticket to decide how to message to the user that the search did not fall within an NC. Please move this ticket to "In Progress" if this clarification is sufficient.
Resources
New ETA Friday Oct 25th EOD