hackingmaterials/pv-vision

pv_vision.transform_crop._cell_crop.detect_vertical_lines needs debugging

Opened this issue · 1 comments

eccoope commented

Was trying to run through tutorials/transform_split.ipynb and noticing a couple of issues.

  1. Easy to fix - when detect_vertical_lines( ) calls split_img( ), an incorrect keyword is used (split instead of n_split) which raises an error
  2. More involved fix - IndexError is raised when detectoutliers( ) is called by detect_vertical_lines( )in line 364. The error is triggered by line 125 in detectoutliers( ). Not sure what is causing this.
X-Chen97 commented

Thanks for the comments. I have fix the bug and tutorials/transform_split.ipynb can run without error now.

Can you provide more details of your second issue? I cannot repeat what you described.