Email sig logo not working
Closed this issue · 7 comments
It should be located at https://mchacks.ca/images/signature.png
I think the issue might be that images/ is not in dist/. When I visit the link, it says not found.
Oh that makes sense since we're only deploying the /dist/ folder. I had added the signature back in, but in /images/signature.png instead of /src/images/signature.png.
Should I just add an /images/ folder into our /src/? Or should I move signature.png back to /static/ and have everyone change their image URL to /static/?
So is it now /dist/images/signature.png which goes to the same URL?
I think the idea is that it's too difficult for everyone to change their signature again, some people use clients that don't allow them to change the HTML directly.
I'm not sure how many people actually deployed their signatures yet. I'd be open to moving it. If we are moving it we should just put it in static with the rest of the assets though.
I'm down to move it if it's not affecting a lot of people. The sooner the better pls. 🙏
yep it was originally in static with the rest of the assets
would be best to move it back there
ok let's do it. Once this issue is closed I'll update the signatures on Notion and ping everyone to change.
Email sig now rests at https://mchacks.ca/static/signature.png