Fix deploy script
loreina opened this issue · 6 comments
When running yarn deploy, git commit -m 'Run build for deploy 🚀 doesn't work right and this error comes up: error Command failed with exit code 1.
@erickzhao I reordered the deploy script so now it works when run, but the git commit -m part still isn't working. I tried putting it at the end of the script and adding a message via command line but nothing changed.
Can we also get it somehow to squash the latest commits in master before pushing to gh-pages?
@loreina Does the script push changes properly? I had git commit -m there to commit changes before pushing to the gh-pages folder.
It pushes changes fine, copies the commit and commit message from master. The issue is changing the commit message (not sure why it's not working).
With the deploy script I edited, this comes up: error Command failed with exit code 129. With this error, deploy is still successful to gh-pages.
@loreina I think that's because you're running a build at some point when you commit your changes, right?
When @krubenok was reporting that the command wasn't doing anything, I think he wasn't manually committing the build after the webpack command was run.
In any case we'd have to define the flow to either commit before or not commit before, or else come up with a script that can handle both cases.
git commit -m commits w/ a message defined after the -m flag. Two things about it:
- If you're only committing as the last part of the command, the command itself won't do anything (or at least, it shouldn't do anything).
- I think the command is failing because
-mrequires a string after the flag to actually have the commit message.