hacknug/tailwindcss-background-extended

Background attachment?

benface opened this issue · 10 comments

benface commented

Tailwind itself already has a backgroundAttachment module since v0.3.0, which generates the same classes as this plugin:

.bg-fixed {
  background-attachment: fixed;
}

.bg-local {
  background-attachment: local;
}

.bg-scroll {
  background-attachment: scroll;
}

Should these classes be removed from this plugin then?

hacknug commented

Thanks for the heads up, I probably missed it somehow. Will release a new version later and another one when/if Adam merges your PR with space and round.

hacknug commented

/remind me to update the plugin in 4 days.

reminders commented

@hacknug set a reminder for Jan 7th 2019

  • 😄1
reminders commented

👋 @hacknug, update the plugin .

hacknug commented

No news at tailwindlabs/tailwindcss#610 yet 😢

/remind me in a week

reminders commented

@hacknug set a reminder for Jan 15th 2019

benface commented

👋 @hacknug, update the plugin .

-- benfacebot

  • ❤️1
hacknug commented

@benface I've just published v1.0.0 which removes support for everything we already have in core, adds tests (which I shamelessly stole from https://github.com/benface/tailwindcss-transforms) and introduces support for backgroundImage which I'm not sure is even needed 🤷‍♂

benface commented

Nice update! 👍