Font artifacts on Radeon RX 5700

Question

Font artifacts on Radeon RX 5700

Closed this issue 2 years ago · 17 comments

OS: Arch Linux
egui_winit_vulkano version: 0.17.0
Graphics card: Radeon RX 5700 (Free driver + vulkan-radeon)

I'm currently observing color artifacts with label/button fonts when using RX 5700, yet the issue does not reproduce on Ryzen 4700U's integrated GPU.

GUI is setup with is_overlay = false and I used minimal.rs as an example.

I'm not sure if this is the correct crate to open the issue, but I don't really know whether the issue is in the integration or in egui itself.

hakolao commented 2 years ago

Alright!

Answer 1 · 2022-07-18T18:28:50.000Z

Here are two screenshots for comparison, first one taken from RX 5700 test, second one from Ryzen 4700U IGPU

Answer 2 · 2022-07-18T18:40:43.000Z

Are you using the crates version or the newest master branch? (Havent bumped the version number yet).

if it’s not the master branch one, do you see the issue there too?

Hard to say though. I’d need to figure out a way to reproduce it.

Does it happen on any other integration? E.g https://github.com/emilk/egui/tree/master/egui-wgpu just to see if it seems specific to my integration.

Answer 3 · 2022-07-18T18:52:21.000Z

Just tested master egui_winit_vulkano with its Cargo.toml revision of vulkano libs, same issue. Did not yet test egui with wgpu backend, as my project is developed using vulkano as a backend.

Answer 4 · 2022-07-18T18:54:01.000Z

Some fonts work, but only the label + buttons not?

Answer 5 · 2022-07-18T18:56:59.000Z

No, all the components with text I tested so far have this issue

Answer 6 · 2022-07-18T18:58:17.000Z

I was thinking that the wgpu integration test could help pinpoint if it’s vulkan (you can select vulkan backend with it) or egui. And then if it does not show there, then it’s probably bug in this integration.

Answer 7 · 2022-07-18T18:59:50.000Z

Anyway, I can try to see tomorrow if I can find out probable causes

Answer 8 · 2022-07-18T19:36:22.000Z

Tried https://github.com/hasenbanck/egui_example, works fine. Still not sure if I am doing something wrong in my setup with vulkano.
Thanks for looking into this issue!

Answer 9 · 2022-07-19T12:45:02.000Z

Would you be able to attempt with the branch from #17. Let me know if it changes anything for you. It might not...

Answer 10 · 2022-07-19T12:49:56.000Z

Just tried, unfortunately, did not help

Answer 11 · 2022-07-19T12:51:41.000Z

Also, the button texture itself seems fine, it's only fonts that get these artifacts. So I think, there might be some problem with TTF stuff specific to my setup. I will try to experiment with different fonts to see if that changes anything

Answer 12 · 2022-07-19T13:13:41.000Z

I seem to have found the likely cause of the problem: with RX 5700, my output format is A2R10G10B10 (sRGB), whereas with Ryzen 4700U IGPU it's B8G8R8A8. I also noticed that other egui integration libraries do some sRGB-specific conversions in their shaders, so doing the same thing might actually fix the problem.

Answer 13 · 2022-07-19T13:59:22.000Z

Want to try a fix? :)

Answer 14 · 2022-07-19T14:00:34.000Z

Sure. I'll try to port shaders from other crates and see if it fixes the problem

Answer 15 · 2022-07-19T14:00:45.000Z

I merged the little PR anyway, as I had been thinking of doing that earlier, even though it did nothing to address this issue. I added also a new example to run the egui_demo_app so it's better to check everything works correct if you end up fixing this

Answer 16 · 2022-07-20T14:55:34.000Z

This issue should then be resolved, other than the SRGB conversions. I might have to try if I can find a consistent solution to that.

Let me know if you run into anything else!