halfzebra/create-elm-app

Remove unused imports

Closed this issue · 7 comments

janwirth commented

https://github.com/dkodaj/impfix has worked for me on a lot of files with just one error. This would be a killer feature. I now do not need to waste time anymore finding unused imports to clear circular dependencies.

elm-app remove-unused-imports

kornicameister commented

This tool is for elm 0.18. Why not using elm-analyse or elm-lsp? Both of these can be integrated or are already integrated in tooling available for Vim, VSCode or Atom? I am personally using Neovim + ale + elm-lsp and it works great, actively displaying unused imports and not only that.

janwirth commented

The tool has worked for me perfectly fine on a ~10k codebase of elm 0.19 code.

I am not using any of these editors, I am using kakoune. I prefer to have an editor that is not overloaded with plugins and integrations. elm-lsp is a language server and elm-analyse is a general purpose tool. I do not see any of them solving the problem of obsolete circular dependencies with a line of code and within two seconds.

kornicameister commented

I might remember it incorrectly, I haven't stumbled upon this for a long time. But AFAIR Elm does not compile if there's a circular dependency, right? If there's one and it happens to be not used you will remove it anyway :).

elm-lsp runs elm-analyse under the hood and apart from showing unused imports it show unused exports. But I assume you already know this :).

janwirth commented

I think our workflows differ vastly - Probably I need to take a leaf out of your book there.

kornicameister commented

Might be just that :). Anyway, there is one good thing that came out of this. This editor you mentioned seems really nice.

halfzebra commented

Hello Franz!

While I completely agree with the motivation for this improvement, it doesn't look like the tool is being actively maintained. I've decided to close this issue for now.

Please let me know if you have further suggestions or questions!

janwirth commented

Hey Ed!

I am actively using this tool and I would maintain it if necessary. However it was stable for the last year and works perfectly on several k LOC. It has saved me days. I'm not super fussed though because I just add scripts to my package.json doing the job.