hallgren/eventsourcing

add modules support

Closed this issue · 5 comments

hallgren commented
add modules support
hallgren commented

In branch go_modules but need more reading to know if this is correctly done.

lunjon commented

The branch go_modules looks fine to me. May I suggest to add Travis CI to make automated builds and deploys as well? The following travis file would work (I think):

language: go

go:
- 1.13.x

env:
  # Not sure if needed for go 1.13
  - GO111MODULE=on 

jobs:
  include:
    - stage: build
      script:
        - go get ./...
        - go test ./...
      deploy:
        provider: releases
        # Requires that an environment variable named $GH_TOKEN is available,
        # set to a valid GitHub API key.
        api_key: $GH_TOKEN
        skip_cleanup: true
        on:
          branch: master
          tags: true

A new tag on branch master would cause an automated release, which is nice.

hallgren commented

looks interesting, could you create a PR ;)

lunjon commented

Will do!

  • ❤️1
hallgren commented

added modules and travis ci file

  • 👍1