ActionController::Params.to_hash is deprecated and will be removed in rails 5.1

Question

ActionController::Params.to_hash is deprecated and will be removed in rails 5.1

Closed this issue 8 years ago · 5 comments

https://github.com/halogenandtoast/monban/blob/master/lib/monban/services/sign_up.rb#L19

Answer 1 · 2016-05-02T14:19:54.000Z

Should just need to change to to_h

Answer 2 · 2016-05-02T14:22:58.000Z

This would break out of the mass assignment security provided by ActionController::Params. What's the reason to call `to_hash` there in the first place?

Answer 3 · 2016-05-02T14:28:14.000Z

@derekprior The original reason was to get the additional values (like username) that Monban doesn't know about, to_h doesn't break out of mass assignment security in rails 5. See http://edgeapi.rubyonrails.org/classes/ActionController/Parameters.html#method-i-to_h

Answer 4 · 2016-05-02T14:29:22.000Z

This is the case for rails 4 as well so I'm going to issue this fix immediately.

Answer 5 · 2016-05-02T14:32:16.000Z

@derekprior care to look at #45