[Feature Req] Including Planck 18 Cosmology
Closed this issue · 7 comments
Describe the solution you'd like
I believe it would be nice to add the Planck18 cosmology from astropy
If it is also possible, I would like to contribute to the project by adding this feature. I guess first I have to add Planck18 to the
from astropy.cosmology import FLRW, WMAP5, WMAP7, WMAP9, Planck13, Planck15 # noqa
line in src/hmf/cosmology/cosmo.py and later on update the docs.
I also want to contribute to the project in general. In current stage, I guess I can try to help to improve the docs and maybe try to do some other small stuff. It's also kind of hard for me to learn and follow the development steps, since I have never contributed to any project before but I'll try my best to learn and follow them.
@seVenVo1d your contributions will be much appreciated! The best way to learn is to play around with it and make small contributions!
You're right, adding Planck18 should be as easy as adding it to that line. Documentation updates are also a very valuable contribution.
That is great to hear. Then, I am going to try to do some updates and create a PR until the end of the week.
I know might not be the perfect place to share this but I have seen this in broad_overview.ipynb and I couldn't be sure if its a typo or something done on purpose.
for power, tr, label in get_hmf(req_qauntities=['power'],
it's written as qauntatities ... I can try to fix it but I couldn't find where that function reside.
PS: Also in tests folder, some files have Planck13 cosmology and some others Planck15. is it expected..?
The get_hmf function is in here: https://github.com/halomod/hmf/blob/dev/src/hmf/helpers/functional.py -- the spelling should be req_quantities so you could definitely fix that if it's wrong! It's fine if some files use one cosmo and others use another.
The get_hmf function is in here: https://github.com/halomod/hmf/blob/dev/src/hmf/helpers/functional.py -- the spelling should be req_quantities so you could definitely fix that if it's wrong!
I'll definitely fix that in the next PR.
It's fine if some files use one cosmo and others use another.
That's great.