haltcase/glob

`includeDirs` should default to true, as in D, python, unix find, unix ls, etc

timotheecour opened this issue · 2 comments

`includeDirs` should default to true, as in D, python, unix find, unix ls, etc

@timotheecour hmm. It seems more common that I'd want to not match directories, and that's what I'm used to from most libraries in the JS realm. This is a possibility but I don't want to be consistent just for the sake of consistency — it should also be sane.

not a big deal ultimately whichever way you prefer, however here's 1 more argument:
with current default,
walkGlobKinds only entries with returns kind=file (real or symlink), so (with default options), the kind argument isn't particularly useful
with includeDirs defaulting to true, the kind becomes more meaningful