hampusborgos/rme

select doodadbrush bug (context menu)

Zbizu opened this issue · 1 comments

Zbizu commented

select doodadbrush doesn't show in context menu when the brush is in terrain palette only for broken dead trees ids for some reason when an unused brush also uses them

steps to reproduce:

prerequisite: remove all extensions to make sure the issue is possible to reproduce with provided items

  1. create a brush
	<brush name="broken dead trees" type="doodad" server_lookid="8786" draggable="false" on_blocking="false" thickness="12/100">
		<item id="8786" chance="10"/>
		<composite chance="10">
			<tile x="0" y="0"> <item id="8786"/> </tile>
			<tile x="1" y="0"> <item id="8787"/> </tile>
		</composite>
		<composite chance="10">
			<tile x="0" y="0"> <item id="8786"/> </tile>
			<tile x="0" y="1"> <item id="8789"/> </tile>
		</composite>
		<composite chance="10">
			<tile x="0" y="0"> <item id="8785"/> </tile>
			<tile x="-1" y="0"> <item id="8790"/> </tile>
		</composite>
		<composite chance="10">
			<tile x="0" y="0"> <item id="8788"/> </tile>
			<tile x="0" y="-1"> <item id="8791"/> </tile>
		</composite>
	</brush>
  1. add it to terrain palette only
	<tileset name="test">
		<terrain>
			<brush name="broken dead trees"/>
		</terrain>
	</tileset>
  1. launch RME
  2. place the thing
  3. right click it

expected

"select doodadbrush" in context menu

observed

missing that option

Zbizu commented

ok found the problem:

there's an unused brush in doodads.xml:

<brush name="tree stubs" type="doodad" server_lookid="5092" draggable="true" on_blocking="false" thickness="12/100">