hankinsoft/SQLPro

App crash on removing shortcut

Closed this issue · 5 comments

iir-dna commented

Describe the bug
Application crashes if I have an open query editor and go to settings to remove keyboard shortcut (in my case format query)

To Reproduce
Steps to reproduce the behavior:

  1. Connect to a database
  2. Open an empty query editor
  3. Go to preferences
  4. Switch to Keyboard section
  5. Remove Format query shortcut
  6. Click Apply or Apply & Close button

Expected behavior
Preferences window closes, shortcut is no longer set

Screenshots
image

crash-on-shortcut-remove.mp4

crash_log.log

Environment details (please complete the following information):

  • Device: Macbook M1 Pro
  • OS: macOS 14 Sonoma
  • SQLPro app Version: SQLPro Studio Version 2024.15 (Build 111090.5)
  • Installation source: App Store
  • Target database server: PostgreSQL

Additional context
When empty Studio is open and I remove shortcut - everything's fine. It only occurs when query editor is open

hankinsoft commented

Reproduce. I'll get a fix for this submitted for next week. Thank you for providing all the details.

  • 🎉1
iir-dna commented

Thanks for the fix. Feel free to ask for any kind of help regarding testing it

hankinsoft commented

FYI the fix should now be available via the App Store. If you get the chance, please give it a try and let me know if that sorts it out.

iir-dna commented

@hankinsoft have already upgraded via App Store to 2024.20 (Build 111092.5).
Indeed, it now behaves as it should🙏🏻 - not crashing after shortcut being updated and changes applied.
Attaching a vid with confirmation of the fix here.

Appreciate your fast feedback on an issue, and a lightning fast fix. 😌

fixed-crash-on-shortcut-remove.mp4
hankinsoft commented

Awesome, glad to hear it. Thanks for letting me know. If you happen to get the chance, please consider leaving a rating or review. You can do so easily by running the query:

rate;

Cheers!