MetaKernel annotation error
fengluodb opened this issue · 1 comments
fengluodb commented
I found some annotation error in MetaKernel.
- In
forward
,param coord_data: num_batch, 3, H, W
link. But it's not real, inSalsaNextWithMotionAttention
,coor_data
iscurrent_range_image
, it's channel is 5; - In
sample_data
,:return: sample_output: num_batch, num_channel_in * kernel_size * kernel_size, H, W
, link. I think the outout should benum_batch, num_channel * kernel_size * kernel_size, HxW
MaxChanger commented
Thank you for such meticulous coding review.
I took a quick look and recalled that this part of the annotation may be from the original RangeDet, which has not been carefully checked and modified.
-
It really needs to be corrected here, because in fact, any dimension can be passed in here, (x, y, z), or (x, y, z, i, r)
MotionSeg3D/modules/SalsaNextWithMotionAttention.py
Lines 136 to 140 in dc4c95f
-
I think you might be right, I look further into docs doc_mxnet and doc_torch_nn.Unfold, and confirm the tensor shape/size when debugging.
These will be fixed and updated soon.