happo/happo.io

Spurious diffs with iOS-safari

ahobson opened this issue · 4 comments

This happens to us a lot:

image

In particular, it seems like iOS-safari frequently has diffs related to icon assets not loading consistently.

Any advice?

Hi @ahobson! Sorry about this -- these shouldn't be showing up like this. Do you have a link to a report I can look at? You can send it to support@happo.io, I'll investigate to see what's up.

Okay, the theory right now is that we aren't waiting for background images on pseudo elements to finish before we take the screenshot. I'll update this thread once we have a fix. Appreciate the report @ahobson!

The theory was correct. A fix has been deployed to Happo's workers.

Thank you. We had a number of PRs from dependabot this morning and we didn't see this issue at all