happo/happo.io

wrong PREVIOUS_SHA using happo-ci-circleci

ggazzo opened this issue · 2 comments

ggazzo commented

we are testing happo here at Rocket.chat and we faced that script:

PREVIOUS_SHA=$(git merge-base origin/master "${CIRCLE_SHA1}")

my question:
should origin/master be origin/"BASE"?

trotzig commented

You are right, it shouldn't assume master. I'll address this right away, it will probably involve optionally setting a BASE_BRANCH environment variable to override the default.

trotzig commented

Release 3.18.0 was released with a way to set the base branch using the BASE_BRANCH env variable:

BASE_BRANCH=origin/dev npm run happo-ci

Please note that you need to include the full branch name, e.g. origin/dev (and not dev).

  • ❤️1