Support for gnome 45

Question

Support for gnome 45

diegomartarelo opened this issue a year ago · 41 comments

diegomartarelo commented a year ago

Support for Gnome 45

Answer 1 · 2023-09-07T15:37:03.000Z

If you are interested in disabling the titlebars, you can,

copy the CSS from unite@hardpixel.eu/styles/gtk{3,4}/buttons-right/both.css to ~/.local/gtk-3.0/gtk.css
logout
login

Answer 2 · 2023-09-22T12:58:23.000Z

Tried the above - didn't work for me...

Answer 3 · 2023-09-24T13:11:27.000Z

Tried the above - didn't work for me...

File both.css refers to maximized.css and tiled.css.
So, I took unite@hardpixel.eu/styles/gtk4/buttons-right/maximized.css and paste contents to ~/.local/gtk-4.0/gtk.css , 'cause GNOME Shell now uses GTK 4. Works as it must. GNOME 45.0 on Ubuntu 23.10.

UPD. Made a script, but removing titlebar of tiled windows not working.
remove-titlebar-gnome45-user.zip

Answer 4 · 2023-10-02T10:39:20.000Z

Just to say that the comments above re. CSS don't really address the range of needs for support for Gnome 45.

There are various changes regarding the inclusion of modules which are covered here: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils

Of course, there will also be changes to reinstate the use of the topbar for maximised windows and various window info for non-maximised windows. I notice that the 'Window Title is Back' extension does one of these tasks, though it would be amazing if Unite did this for us (better to have one extension we rely on than many).

Thank you for all the amazing work on this extension!

Answer 5 · 2023-10-10T16:24:48.000Z

Arch \ EndeavourOS just got Gnome 45 released to stable this morning. @jonian Please let us know how we might be able to help test and support your team. I am available as a tester.

Answer 6 · 2023-10-10T16:27:01.000Z

Hey @rsramkis, thanks for offering to help. I'm on arch too and got the update. I will try to work on it on the weekend. Very busy with work unfortunately.

Answer 7 · 2023-10-10T16:43:05.000Z

For anyone on arch that updated to gnome 45, disable unite before restart or logout because decorations on CSD apps will be hidden. If you already restarted without disabling unite, you must remove the css injected by the extension in the files below:

~/.config/gtk-3.0/gtk.css
~/.config/gtk-4.0/gtk.css

Answer 8 · 2023-10-10T16:46:38.000Z

Hey @rsramkis, thanks for offering to help. I'm on arch too and got the update. I will try to work on it on the weekend. Very busy with work unfortunately.

I would not rush. Think we have all gone through Gnomes changes the past couple of years breaking the extensions. Suspect in the next 1 to 3 months there will be hot fixes from them as things are found. There seems to be significant changes to the extension development kit. So people should expect a couple months while we see how things evolve.

Answer 9 · 2023-10-10T16:59:04.000Z

~/.config/gtk-3.0/gtk.css
~/.config/gtk-4.0/gtk.css

So are you saying I should remove the configuration lines added by Unite:

File: ~/.config/gtk-3.0/gtk.css

Remove the contents tagged with in the "/* UNITE":

Therefore the following 3 lines will be removed:

/* UNITE windowDecorations */
@import url('/usr/share/gnome-shell/extensions/unite@hardpixel.eu/styles/gtk3/buttons-right/maximized.css');
/* windowDecorations UNITE */

And keep "@import 'colors.css';"

And remove the following:

File: ~/.config/gtk-4.0/gtk.css

/* UNITE windowDecorations */
@import url('/usr/share/gnome-shell/extensions/unite@hardpixel.eu/styles/gtk4/buttons-right/maximized.css');
/* windowDecorations UNITE */

Answer 10 · 2023-10-10T18:57:34.000Z

The error message with Gnome 45

The settings of extension unite@hardpixel.eu had an error:

SyntaxError: import declarations may only appear at top level of a module

Stack trace:

@file:///home/tealk/.local/share/gnome-shell/extensions/unite@hardpixel.eu/prefs.js:4:21
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

Answer 11 · 2023-10-14T13:32:43.000Z

There is now an GNOME 45 branch that is WIP. I have tested only the default settings. What does not work:

Appmenu, has been removed from gnome, a custom appmenu will be created
Titlebar actions on top panel click (left, right, middle)

If anyone wants to install the gnome 45 branch and report issues, that would be helpful.

Answer 12 · 2023-10-14T15:06:17.000Z

Installed the Gnome 45 branch, no issues thus far. Will report if anything comes up. Thanks for all the work you put in to this!

Answer 13 · 2023-10-14T16:39:22.000Z

There is now an GNOME 45 branch that is WIP. I have tested only the default settings. What does not work:
1. Appmenu, has been removed from gnome, a custom appmenu will be created

2. Titlebar actions on top panel click (left, right, middle)
If anyone wants to install the gnome 45 branch and report issues, that would be helpful.

When we are making changes to the settings of the extension ... do only these 2 files get modified:

~/.config/gtk-3.0/gtk.css
~/.config/gtk-4.0/gtk.css

This will help me figure out if the setting files are being updated correctly.

Answer 14 · 2023-10-14T18:05:55.000Z

@jonian

One of the items I can't seem to get to work is to see the application title bar in the top bar. Usually I maximize the application, and when the application is in focus the title shows in the top bar.

The tested applications:

Firefox
Cider (flatpak)
Gnome Text Editor (native Gnome app v45)
Signal (Arch repository app)

These are my settings:

Firefox Example:

Tests that have passed:

Confirmed Extend top bar left box shifts time\date from center to the right before the system tray icons (network, volume control, battery life).
Confirmed Extend top bar left box can be toggled on and off and title bar re-draws correctly.
Confirmed when Steam runtime launches that Steam icon is show in system tray of the top bar.
Confirm when "Show system tray in top bar" is toggled that Steam icon will appear and then disappear from the left of the native system tray icons.
Confirmed the "Show windows button in top menu" when maximized.
Confirmed the "Show windows button in top menu" always for the in focus program..
Confirmed the Top Bar Windows button change based on the theme chosen (Awaita, Breeze, Dracula and Qogir tested).
Confirmed the "Top bar windows button position is placed (left and right).
Confirmed "Hide Activities button" always works when applications in windows or maximized.

Answer 15 · 2023-10-14T19:13:32.000Z

@rsramkis As I said in my initial post appmenu is not working (not ready yet, gnome removed it), that's why you can't see the application title bar in the top bar.

Answer 16 · 2023-10-15T08:59:08.000Z

Appmenu has been added in gnome45 branch. The extensions needs some minor tweaks. The titlebar actions feature still not working.

Answer 17 · 2023-10-15T11:31:31.000Z

Version 73 that supports only GNOME 45 is available for download in the releases page. Make sure to watch the repository for new releases if you want to get updates for new versions. I will not publish this or any other extension on gnome extensions website any more.

Answer 18 · 2023-10-15T16:59:36.000Z

Thanks for your hard work (and on your weekend of all things). Having the title of the application in the top bar and all the tuning in the extension really kept me holding onto Gnome. I don't quite get whey Gnome does not just make these features native to the desktop instead of all the extension development.

I'm going to just patiently wait (watch the Unite releases) page before I re-deploy the extension. I've really just shut off all my extensions living in vanilla land till December when I may turn things back on.

Answer 19 · 2023-10-16T12:03:16.000Z

@jonian

I will not publish this or any other extension on gnome extensions website any more.

Can we know, why? I am just curious. It is not a problem to follow the releases here too. (Or I will download from AUR.) 🙂

Answer 20 · 2023-10-16T12:43:09.000Z

@7system7 I looks like the review process has changed from checking if an extension does anything malicious and it works in general to the reviewers asking for changes that are personal opinions on how an extension should be coded. I'm not willing to do any changes, in this or the other extensions I maintain, just to satisfy the review process.

I also maintain the AUR package, so anyone that uses arch or arch-based distros will get the updates as soon as they are released.

Answer 21 · 2023-10-16T12:51:37.000Z

I can absolutely understand your opinion. Thank you for your work!

Answer 22 · 2023-10-16T14:56:59.000Z

I don't want to create separate issues (but I can create if needed), just one question and one minor bug (both are regressions, I guess).

First, on GNOME 44 version there was an icon of application near its title:

On version 73 of this extension there's no icon (and no space for icon too). Is it intentional?
I don't see this icon in readme.md but I see it in other issues on this repo (for gnome <45 ofc). I can't show gnome 45 screenshot because I reverted back to gnome 44 until 45 is stable. For the same reason I can't test version 74, though I see that changes are purely internal (from this commit) and there won't be any change.

Second, "Top bar window buttons" are hidden when any menu on top bar is opened (be it notification menu, win+S, etc). On gnome 44 I see that focus is lost on those actions, but buttons aren't hidden, they stay in place. In combination with clipboard menu extension this behavior is very annoying: you click and nothing happens, because button moved right.

Also, I use AUR package of this extension.

UPD: now that I created an issue I look stupid and want to say why didn't I create an issue. It is simple: I was afraid that they are a known issue (both icon and buttons) and migration was still going, but I completely forgot that wayland is mainstream now.

Answer 23 · 2023-10-16T15:05:11.000Z

@HeroBrine1st, it is better to open new issues about these.

First, on GNOME 44 version there was an icon of application near its title:

That is the appmenu that was part of gnome until 44. Now removed from gnome 45.
I implemented a minimal custom appmenu only to support unite settings for window title.

Second, "Top bar window buttons" are hidden when any menu on top bar is opened (be it notification menu, win+S, etc)

This looks like a regression, open a separate issue for it. (I can't replicate it)

Answer 24 · 2023-10-16T15:12:25.000Z

@7system7 I looks like the review process has changed from checking if an extension does anything malicious and it works in general to the reviewers asking for changes that are personal opinions on how an extension should be coded. I'm not willing to do any changes, in this or the other extensions I maintain, just to satisfy the review process.

I also maintain the AUR package, so anyone that uses arch or arch-based distros will get the updates as soon as they are released.

please update the README.md file to update the install process, the mention to use gnome extensions for gnome shell version up to gnome 44, and to install from the github repository for Gnome 45 and newer versions, and specific ones for Linux distros (Debian, Ubuntu, Archlinux ...)

Answer 25 · 2023-10-16T16:32:16.000Z

Here would be good too, if it is possible w/o the review process. (I saw the comment, but it can be disappeared later.)

Answer 26 · 2023-10-17T07:40:50.000Z

@HeroBrine1st I added support for application icon and busy loader in appmenu, no need to open an issue.

@7system7 and @ysolis I will update the installation instructions and add a message in the gnome extensions website (no review needed). I was thinking of using OBS to provide repositories for multiple distros. If anyone has experience with OBS that would be really helpful.

Answer 27 · 2023-10-23T13:39:16.000Z

Is it possible to get the new activity indicator working with Unite?
If I turn on Activities, it only shows the text.

Answer 28 · 2023-10-23T13:43:55.000Z

Hi @ismasou, there is a new setting in "appearance" tab called "Use text in activities button"

Answer 29 · 2023-10-23T13:45:39.000Z

@jonian Sorry I didn't see that, thanks for the info.

Answer 30 · 2023-10-25T20:10:17.000Z

Hello,

I just updated the extension from AUR under Manjaro. I still have the following error :

The settings of extension unite@hardpixel.eu had an error:

SyntaxError: import declarations may only appear at top level of a module

Stack trace:
_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:23:33
ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:10:4
OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:124:33
async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:186:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:22:13
run@resource:///org/gnome/gjs/modules/script/package.js:206:19
start@resource:///org/gnome/gjs/modules/script/package.js:190:8
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

Answer 31 · 2023-10-25T20:33:42.000Z

Hi @945fc41467, it looks like it still loads the old version. Did you logout after the extension update? What is the unite version in the extensions application?

Answer 32 · 2023-10-25T20:35:59.000Z

Hi,
I log out/log in after update, but I didn’t reboot. Isn’t enough ?

The version displayed is 77.

Answer 33 · 2023-10-25T20:40:56.000Z

Logout should be enough. The version is correct, 77 is the latest. Maybe try reboot, I don't know what is the issue.

Answer 34 · 2023-10-25T20:46:15.000Z

Rebooting didn’t make the job. How can I provide more information ?

EDIT : I just checked : the version of Gnome is 44.5 and not 45. Can this be the cause of the problem ? Maybe the extension indicate it is compatible with 44 or 45, but not 44.5 ? It’s just an idea.

Answer 35 · 2023-10-25T20:50:25.000Z

That is a manjaro issue, not an issue with the extension. You might get better help if you ask in the manjaro forums.

Answer 36 · 2023-10-25T21:04:34.000Z

I will ask. Thank you very much.

Answer 37 · 2023-10-25T21:06:35.000Z

@945fc41467 what is the output of:

cat /usr/share/gnome-shell/extensions/unite@hardpixel.eu/prefs.js

and

ls ~/.local/share/gnome-shell/extensions

Answer 38 · 2023-10-26T06:33:54.000Z

import Adw from 'gi://Adw'
import GLib from 'gi://GLib'
import GObject from 'gi://GObject'
import Gtk from 'gi://Gtk'
import { ExtensionPreferences } from 'resource:///org/gnome/Shell/Extensions/js/extensions/prefs.js'
import * as Theme from './theme.js'
import * as Convenience from './convenience.js'

const PrefsWidget = GObject.registerClass(
  class UnitePrefsWidget extends Gtk.Box {
    _init(params) {
      super._init(params)

      this._settings  = Convenience.getSettings()
      this._buildable = new Gtk.Builder()
      this._themes    = new Theme.WindowControlsThemes()

      this._loadTemplate()
      this._loadThemes()

      this._bindStrings()
      this._bindSelects()
      this._bindBooleans()
      this._bindEnumerations()
      this._bindIntegers()
    }

    _loadTemplate() {
      const template = GLib.build_filenamev([Convenience.getPath(), 'settings.ui'])
      this._buildable.add_from_file(template)

      this._container = this._getWidget('prefs_widget')
      this.append(this._container)
    }

    _loadThemes() {
      const widget = this._getWidget('window-buttons-theme')
      const themes = this._themes.available.sort((a, b) => {
        return a.uuid < b.uuid ? -1 : a.uuid > b.uuid ? 1 : 0
      })

      themes.forEach(theme => {
        if (theme.uuid !== 'default') {
          widget.append(theme.uuid, theme.name)
        }
      })
    }

    _getWidget(name) {
      let widgetName = name.replace(/-/g, '_')
      return this._buildable.get_object(widgetName)
    }

    _bindInput(setting, prop) {
      let widget = this._getWidget(setting)
      this._settings.bind(setting, widget, prop, this._settings.DEFAULT_BINDING)
    }

    _bindEnum(setting) {
      let widget = this._getWidget(setting)
      widget.set_active(this._settings.get_enum(setting))

      widget.connect('changed', combobox => {
        this._settings.set_enum(setting, combobox.get_active())
      })
    }

    _bindStrings() {
      let settings = this._settings.getTypeSettings('string')
      settings.forEach(setting => this._bindInput(setting, 'text'))
    }

    _bindSelects() {
      let settings = this._settings.getTypeSettings('select')
      settings.forEach(setting => this._bindInput(setting, 'active-id'))
    }

    _bindBooleans() {
      let settings = this._settings.getTypeSettings('boolean')
      settings.forEach(setting => this._bindInput(setting, 'active'))
    }

    _bindEnumerations() {
      let settings = this._settings.getTypeSettings('enum')
      settings.forEach(setting => this._bindEnum(setting))
    }

    _bindIntegers() {
      let settings = this._settings.getTypeSettings('int')
      settings.forEach(setting => this._bindInput(setting, 'value'))
    }
  }
)

export default class UnitePreferences extends ExtensionPreferences {
  fillPreferencesWindow(window) {
    const pages  = [
      { name: 'general', icon: 'emblem-system-symbolic' },
      { name: 'appearance', icon: 'emblem-photos-symbolic' }
    ]

    const widget = new PrefsWidget()

    pages.forEach(({ name, icon }) => {
      const page  = Adw.PreferencesPage.new()
      const group = Adw.PreferencesGroup.new()

      const label = widget._getWidget(`${name}_label`)
      const prefs = widget._getWidget(`${name}_prefs`)

      page.set_name(name)
      page.set_title(label.get_text())
      page.set_icon_name(icon)

      prefs.unparent()
      group.add(prefs)

      page.add(group)
      window.add(page)
    })

    window.set_default_size(620, 665)
    widget.unrealize()
  }
}

and

appindicatorsupport@rgcjonas.gmail.com
blur-my-shell@aunetx
caffeine@patapon.info
clipboard-indicator@tudmotu.com
date-menu-formatter@marcinjakubowski.github.com
desktop-cube@schneegans.github.com
hibernate-status@dromi
io.github.mreditor.gnome-shell-extensions.scroll-panel
lockkeys@vaina.lt
nightthemeswitcher@romainvigier.fr
panel-corners@aunetx
system-monitor-next@paradoxxx.zero.gmail.com
tactile@lundal.io
task-widget@juozasmiskinis.gitlab.io
transparent-top-bar@ftpix.com

Answer 39 · 2023-10-26T14:29:24.000Z

@945fc41467 those look fine, you are using the gnome 45 compatible version. Are you sure you are on gnome 45?

It looks that manjaro is still on gnome 44.5 from what I can see here. If you are not on gnome 45, you should downgrade unite to v72

Answer 40 · 2023-10-28T08:21:44.000Z

Hi, @jonian. As I said above : yes, it is 44.5. I first though it is Gnome 45, because I updated Gnome one week ago and it broke the extension. So, I though it was linked with this ticket. Did the maintainers skip the version 44.5 or something like that ?

I hope it will be solved when Manjaro will update Gnome.

Answer 41 · 2023-11-07T14:24:39.000Z

@7system7 I looks like the review process has changed from checking if an extension does anything malicious and it works in general to the reviewers asking for changes that are personal opinions on how an extension should be coded. I'm not willing to do any changes, in this or the other extensions I maintain, just to satisfy the review process.

That's a concerning development. The popular argos extension had similar bad experiences with the review process... p-e-w/argos#108 (comment)

Are you willing to say a bit more about your experiences? If yes, I'll be volunteering to raise awareness to these issues somewhere in the GNOME community. (I still need to figure out what is the most promising place to complain about this.)