Segmentation Fault: library should check for data length and raise
Closed this issue · 2 comments
fabn commented
I think there is no bound checking somewhere in your C code, because if I pass too much data to the encode
method I get a segmentation fault in 1.3.4
Minimal sample to reproduce: https://gist.github.com/1049889
This could be a big problem in a web app because it takes down the whole server process.
jgdavey commented
This should be fixed as of this commit: 845b489f2caacdd700c1
I'll try to get a release out soon.
fabn commented
Yes, it does solve the problem. I tried it installing your gem from github and now my example raise an ArgumentError