harrystech/arthur-redshift-etl

Fix caller information in logging of run function

tvogels01 opened this issue · 1 comments

Summary

When logging in run of db.py, the caller is prefixed to the message. It should be part of the log module information instead.

Details

Minor thing that I once thought about and didn't finish when pulling in calls to run.

Currently:

2017-12-22 14:09:51,432 29F95BAFCB274650 INFO etl.db (MainThread) [db.py:238] (set_redshift_wlm_slots) Using 4 WLM queue slot(s) for transformations

Chould be:

2017-12-22 14:09:51,432 29F95BAFCB274650 INFO etl.load.set_redshift_wlm_slots (MainThread) [db.py:238] Using 4 WLM queue slot(s) for transformations

We should check how easy this is to find in logs or what it would improve.

Implemented as a hybrid of using the correct logger but leaving the method as is.

2019-03-25 15:39:58,407 129A2F86ECAA4903 INFO etl.load (MainThread) [db.py:240] Using 4 WLM queue slot(s) for transformations

Part of https://github.com/harrystech/arthur-redshift-etl/tree/v1.8.4