harshmangalam/qwik-x

Add bottom navigations on mobile screen

harshmangalam opened this issue · 4 comments

harshmangalam commented

On mobile screen add bottom menu navigation
Add menu icons and link to their respective pages

  • Home
  • Login
  • Explore
  • Bookmark
  • Profile
  • Create post

Pick menu icons and links from sidebar component.

MokshagnaV commented

I can work on it. Please assign it to me

  • 👍1
MokshagnaV commented

I have done with this issue.

Before login:
image

After Login:
image

The post function is also working
image

and logout is also working
image

I have reused the existing components to make those work

Please review the design. If it's okay, i will open a pull request to main branch

harshmangalam commented

Awesome. Please raise PR on 1 oct then your pr will be considered by Hacktoberfest.

  • 😄1
MokshagnaV commented

Thank you.
Till then can i work on other issue?

I have a doubt.

If i work on other issues too. How it is possible to merge?
don't we get conflicts?

And

Is this amount of contribution is enough to a count as one PR in hacktoberfest?