harttle/liquidjs

Bug in release artifact process?

aviflax opened this issue · 3 comments

aviflax commented

I just downloaded the release artifact (liquid.browser.umd.js) for both the 10.9.1 and 10.9.2 releases, and I found that the version numbers in the source are offset by -1.

In other words, in the 10.9.1 artifact I found this comment: * liquidjs@10.9.0, https://github.com/harttle/liquidjs and this statement: var version = '10.9.0';

and in the 10.9.2 artifact I found this comment: * liquidjs@10.9.1, https://github.com/harttle/liquidjs and this statement: var version = '10.9.1';

NBD, just letting you know.

harttle commented

@aviflax thank you for calling out!

I'm trying to fix this in 67a5b22 . Let's see if we can make it working.

  • 👍1
harttle commented

Ha! seems fixed:

image

Closing, feel free to reopen if there's still problems on your side.

  • 👍1
aviflax commented

Great! My pleasure. Nice work!