harvard-lil/h2o

Pull from legal document source logic is missing a check on updated date

Closed this issue · 1 comments

Changes introduced in #1956 were missing a key logic step: after checking whether a local copy of a legal document was "old" (more than a year since it was created), the copy retrieved from upstream should have been further checked whether it was more recent than the local copy before a new version was created. Instead it is always creating a new version.

There are utility functions to check this that should be used here and there should be test coverage to assert this is fixed.

After further investigation, we decided the desired behavior here was to never update (create a new copy) of an existing LegalDocument.