harvardnlp/pytorch-struct

Possible bug in to_event method

kmkurn opened this issue 4 years ago · 1 comments

kmkurn commented 4 years ago

pytorch-struct/torch_struct/distributions.py

Line 232 in 8c8c14e

return self.struct.to_parts(sequence, extra, lengths=None)

I think lengths=None should be just lengths?

srush commented 4 years ago

Thanks! Need more length unit tests.