hashicorp/go-azure-sdk

`List[XXX]Complete` should return the last HttpResponse

Closed this issue · 1 comments

tombuildsstuff commented

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Service Used

API Versions Used

Description

Example:

go-azure-sdk/resource-manager/sql/2023-02-01-preview/replicationlinks/method_listbydatabase.go

Lines 21 to 23 in 4b17f17

type ListByDatabaseCompleteResult struct {
Items []ReplicationLink
}

The ListByDatabaseComplete method returns only a slice of the result object - which makes sense in the happy path, however when the API does something unexpectedly (like returning a 404 when the list contains no items) - the ListByDatabaseCompleteResult object doesn't contain the HTTP Response, meaning it's not possible to validate this).

As such we'll want to extend the List[XXX]Complete method such that both it and it's List[XXX]Result:

  1. Return the Result as a pointer (to handle the unhappy path)
  2. Add the last HTTP Response (so that we can handle 404's etc)

References

No response