hashicorp/go-slug

Avoid entering excluded directories

Closed this issue · 5 comments

skeggse commented

Let's say we're in a large monorepo, and we'd like to exclude all the node_modules/ directories (they might not be checked in, even). It'd be nice if I could put node_modules/ in the .terraformignore file and have it not even traverse that directory - it seems that's how it currently works, because the total runtime for Pack seems to remain the same even with that directive.

skeggse commented

Hey @brandonc - any interest in moving this along? It'd help a lot for organizations that stick their terraform in a mixed-use monorepo, along with #20.

brandonc commented

@skeggse I'll be glad to evaluate this. I need a few more days, though! Thanks for calling it out, it's helpful to know this is still relevant to you

  • 👍1
skeggse commented

Sounds good, thanks! I forgot to link to the pull request - #21 implements the improvements I'm looking for :)

felipeplets commented

This is a performance problem in our monorepo. Thank you for raising it and proposing a PR @skeggse.

brandonc commented

@felipeplets @skeggse This is now available as of terraform v1.7.0-rc1. The docs were modified slightly with new guidance. Would love to know if this solved your performance problem.

  • ❤️1