hashicorp/terraform-github-actions

Terraform Plan: comment not formatted correctly

Closed this issue · 5 comments

alexbde commented

Since terraform-github-actions@v0.5.x comments from terraform plan action are no longer formatted correctly.

See following screenshot. First comment is from terraform-github-actions/plan@v0.4.6, second comment is from terraform-github-actions@v0.5.2

Terraform Plan Comment

sudomateo commented

Hello @alexbde. Are you able to send me the raw text of that comment?

I pushed a branch named commenting-improvements that should fix this issue. Would you be able to test that branch and see if that resolves the issue for you?

uses: hashicorp/terraform-github-actions@commenting-improvements
alexbde commented

Much better but still missing colored highlighting of create/update/delete:

Image

sudomateo commented

@alexbde I pushed another change to that branch. Should be good to go now. I'm not a huge fan of the implementation honestly. In order to have GitHub highlight a diff, the + or - symbols need to be the first character on the line. As a result, the indentation will no longer be preserved if users wish to see colors in their comments.

alexbde commented

@sudomateo I understand. Indentation is more important than coloring so I'm fine with that. Thank you for quick solution! :)

sudomateo commented

Awesome. I'm going to fix the formatting but revert the highlight. Thank you for posting this issue!

  • 👍1