[FEAT] Add an option to retrieve rest of the secrets if others are missing
Opened this issue · 6 comments
Is your feature request related to a problem? Please describe.
I tried using multiple secrets, but if one of the secret paths is wrong or the key is missing, other secrets are also not retrieved. Entire job fails. In our case, we were retrieving a secret and slack url. Since the secret path was wrong, the slack url was also not retrieved and the message never got posted in the slack channel.
Describe the solution you'd like
I am not sure if we should fail the entire job or not. Maybe if all the keys are wrong then fail. Or add a not required option for this.
Describe alternatives you've considered
Make sure the secret path is correct and it is present in the vault.
Additional context
None
Anybody working on it or do we have some workaround. if not we can try to work on it?
@pgmanutd I can see the value in an enhancement like this. I will bring it up with the team to see if this is something we want to do.
@fairclothjm How long it can take to add this enhancement. We would need to decide to use this or write our own. Is there anything I can help with?
@akshaychopra5207 Hi, I have a branch that implements the feature. It needs unit and e2e tests added and maybe some more testing and verification. Unfortunately, I don't have cycles to work on it at this time. If you or anyone else wanted to pick it up from there I would help to review it and get it merged.
Did we already get a way forward on this?
@akshaychopra5207 the branch link you shared loads an empty diff