test-unix fails on FreeBSD and MacOS

Question

test-unix fails on FreeBSD and MacOS

Bodigrim opened this issue 4 years ago · 4 comments

I crafted GitHub Actions to demonstrate this: https://github.com/haskell/time/runs/1685500304?check_suite_focus=true#step:5:3201

AshleyYakeley commented 4 years ago

Fixed!

Answer 1 · 2021-01-11T20:31:49.000Z

The test-unix suite tests two things: that formatTime works correctly, using GNU strftime as a reference, and that getTimeZone respects the TZ environment variable. These things don't exist on Windows, which is why they're in a separate suite.

It looks like the failures are caused by strftime behaving differently on BSD (and MacOS) than on GNU. Probably the simplest thing to do would be to not run the formatTime tests on non-GNU platforms.

Answer 2 · 2021-01-12T00:02:32.000Z

Yeah, it seems to be because of Glibc extensions (see https://man7.org/linux/man-pages/man3/strftime.3.html#NOTES) unsupported by BSD platforms.

(BTW I can raise a PR with these GitHub Actions, if you wish, or feel free to cherry-pick them yourself)

Answer 3 · 2021-01-12T00:05:33.000Z

Sure, make a PR for the GH Actions. Thanks!