history_size remains to 28800
Adorem opened this issue · 4 comments
Problem/Motivation
Hi,
Like describe here: #61 I also see memory leaks.
Then I update the addon from v0.7.1 to v0.8.0 to take advantage of this correction:
302a49a
Expected behavior
In /etc/glances.conf I expect the value for history_size to be 0
Actual behavior
but it remains to 28800
Steps to reproduce
Update from from v0.7.1 to v0.8.0
Proposed changes
For the moment as a workaround I manually update /config/glances/glances.conf to include this change and keep it through the addon restart.
👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be useful.
The change updates the defaults from when first installing, it doesn't change any existing config, as you can set it yourself.
Thanks for your answer. I remembered that vscode addon was able to update the config if it was unchanged by the user as explained here:
https://github.com/hassio-addons/addon-vscode/blob/master/vscode/DOCS.md#resetting-your-vscode-settings-to-the-add-on-defaults
And it seems to be thanks to this code:
https://github.com/hassio-addons/addon-vscode/blob/master/vscode/rootfs/etc/cont-init.d/code-server.sh
Maybe something that can be used here too?
GitHub
Visual Studio Code - Home Assistant Community Add-ons - hassio-addons/addon-vscode
Visual Studio Code - Home Assistant Community Add-ons - hassio-addons/addon-vscode
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.