hats-finance/HATs-Arbitration-Contracts-0x79a618f675857b45934ca1c413fd5f409cf89735

Vaults will not remain undestroyable after EIP-4758 implementation

Opened this issue · 1 comments

Github username: --
Submission hash (on-chain): 0x013b8f250b24421352d875f4e429ba781770429c144298172fc00cec16953930
Severity: low

Description:
Description

After EIP-4758, the SELFDESTRUCT op code will no longer be available. According to the EIP, "The only use that breaks is where a contract is re-created at the same address using CREATE2 (after a SELFDESTRUCT)".

Every function involving the use of the selfdestruct will fail unexpectedly and the lock will still remain intact. FOr instance, lock owners will no be able to revoke the locks.

Attachments

  1. Proof of Concept (PoC) File

TokenLock.release() L153

TokenLock.withdrawSurplus() L172

TokenLock.revoke() L189

TokenLock.trySelfDestruct() L447

  1. Revised Code File (Optional)

I'd suggest reworking the contract architecture to avoid the issue.

duplicate of #57