hauler-dev/hauler

[feature] save all images referenced while saving helm chart

Opened this issue · 4 comments

wcrum commented

Is this Feature/Enhancement related to an Existing Problem? If so, please describe:

  • This feature is not related to any existing problem.

Describe Proposed Solution(s):

  • While adding Helm chart to the Hauler, expose a flag such as hauler store add chart [flags] --add-images in which it unpacks and templates base helm chart and add images to image store.

Describe Possible Alternatives:

  • Manually do it?

  • Currently if Hauler users want to save images associated to helm charts they have two first save the helm chart, then download the helm chart separately and try to pull images from the tgz.

# example getting helm chart and images
hauler store add chart hauler-helm --repo oci://ghcr.io/hauler-dev
helm pull oci://ghcr.io/hauler-dev/hauler-helm
helm template hauler hauler-helm-1.1.1.tgz| grep image: | sed -e 's/[ ]*image:[ ]*//' -e 's/"//g' | sort -u
> hauler/hauler-debug:1.1.1
> hauler/hauler:1.1.1
> rancher/kubectl:v1.31.3

Reference: https://stackoverflow.com/questions/60892265/extract-docker-images-from-helm-chart

zackbradys commented

hey @wcrum... I'm moving this out of v1.2.0 since the PR was closed. Hope you are able to reopen it and contribute this feature to the project!

atoy3731 commented

Another thing with regards to this. Annotations in the Chart.yaml should be taken into account when aggregating the list of images: https://github.com/helm/community/blob/main/hips/hip-0015.md

sohooo commented

It would really be great if this would be a hauler feature. Currently we're using https://github.com/nikhilsbhat/helm-images to get a list of images, but this misses a couple of images (e.g. HelmChartConfig).

wcrum commented

This work was done here - #380, there are known issues as after templating helm into individuals manifests, it essentially greps for images and then as well does save.

The known issue, is if the helm chart utilizes CRDs that it can cause issues as CRDs do not follow the same specification as standard kinds.

Due to personal reasons I simply have not had time to finish this, feel free to use my work and finish the PR.