haven-life/persistor

handle null in getTemplateFromKnexPOJO

kevinhuang12345678 opened this issue · 2 comments

kevinhuang12345678 commented

in PersistObjectTemplate.getTemplateFromKnexPOJO, if value=null for isRemoteDoc, it logs:
ERROR: query[getTemplateFromKnexPOJO]: (__amorphicContext={} component="persistor" module="query" activity="getTemplateFromKnexPOJO" data="there was a problem. remote object key must be a string")

it shouldn't log out the Error.

srksag-zz commented

@nsaenz7 - I think this is S3 implementation. Do you want to look into this.

kevinhuang12345678 commented

yes. it is for S3 implementation. i can look into it. should i create pull request from here? the latest version is 5.5.0?