Disolving FavTriggersFragment into TriggersFragment

Question

Disolving FavTriggersFragment into TriggersFragment

Closed this issue 8 years ago · 8 comments

I propose dissolving FavTriggersFragment into TriggersFragment. FavTriggersFragment and TriggersFragment have everything in common except at TriggersFragment data come from rest api at FavTriggersFragment data come from store.

Answer 1 · 2017-03-15T18:12:03.000Z

Can I work on this

Answer 2 · 2017-03-15T18:12:53.000Z

@garg-anuj I would like to work on it as well.

Answer 3 · 2017-03-15T18:14:32.000Z

@free4murad Lets pick only one issue at a time. Please finish #144 for next issue.

Answer 4 · 2017-03-15T18:14:50.000Z

@pg301 Go for it

Answer 5 · 2017-03-15T18:15:31.000Z

@garg-anuj Thanks 👍

Answer 6 · 2017-03-16T08:07:08.000Z

@garg-anuj I have replaced FavTriggerFragment but there is a small glitch now. Only when I refresh, this update comes. I have added the code in setUpForcedTrigger. Can you please guide me through.

Answer 7 · 2017-03-16T08:11:32.000Z

@garg-anuj I think I fixed it. I removed setupstate method from triggerFragment

Answer 8 · 2017-03-16T08:16:01.000Z

@pg301 What you can do is place the PR with WIP (Work in progress) tag. So that we can help you out better