Unit tests for models needed to be updated

Question

Unit tests for models needed to be updated

KeenWarrior opened this issue 8 years ago · 14 comments

KeenWarrior commented 8 years ago

Recommended to break down in multiple PR

Answer 1 · 2017-03-18T03:09:29.000Z

@garg-anuj Would like to work on this.

Answer 2 · 2017-03-18T05:15:44.000Z

@sauravvishal8797 Go on

Answer 3 · 2017-03-18T10:57:07.000Z

@garg-anuj
Is this assigned to @sauravvishal8797
or can I work on this?

Answer 4 · 2017-03-18T15:29:07.000Z

@free4murad Just assigned this to @sauravvishal8797 to avoid confusion

Answer 5 · 2017-03-18T15:35:29.000Z

@garg-anuj Can you elaborate a little more in the description what do you expect here?

Answer 6 · 2017-03-19T11:33:03.000Z

@danielpassos Yeah sure

Models under org.hawkular.client.android.backend.model need to have updated constructors annotated with @VisibleForTesting and unit tests.

Some models don't have tests at present so new tests needed to be created for them

Answer 7 · 2017-03-20T16:37:17.000Z

@danielpassos @garg-anuj I think this issue requires significant amount of work. Can I start writing tests for some modules.

Answer 8 · 2017-03-20T16:47:18.000Z

@danielpassos @garg-anuj
Actually I haven't completed any GSoC issue yet.
So if @sauravvishal8797 will not be working on it please assign it to me.

Answer 9 · 2017-03-21T01:05:29.000Z

@pg301 @free4murad Still working on this one.

Answer 10 · 2017-03-21T04:12:40.000Z

@sauravvishal8797 Cool! Please let me know if you need some help. I have updated some constructors in a3f0b95 so if you want you can skip that part.

Answer 11 · 2017-03-21T06:38:42.000Z

@sauravvishal8797 The issue description suggests that we break down the issue in multiple PRs. I think we can split some work. Please let me know your progress and we can decide on the remaining modules.

Answer 12 · 2017-03-21T07:09:11.000Z

@free4murad GSoC issue only means that given issue will be probably easy one to tackle and nothing more. So find issues and register them. Thats it 😉

Answer 13 · 2017-03-21T07:14:15.000Z

@pg301 Yeah cool! For the constructors part we also needed to update the constructor for trigger model as the tests were failing for the trigger model, so I have updated it here 55b7162 and had to set minifyenabled to false to avoid the warnings.

Answer 14 · 2017-03-22T13:42:14.000Z

@sauravvishal8797 @garg-anuj The recently opened pull requests 9e85a15 only fixes 'updating visibleForTesting annotation'. There are a number of models which do not have corresponding tests. I would like to write tests for the remaining models and will send a PR.