hawkular/hawkular-android-client

App crashes in API versions 19 and below

pg301 opened this issue · 6 comments

pg301 commented

Here's the log: https://paste.ubuntu.com/24405633/

Demo:
app crash

I think I know the fix, can I send a PR for this @garg-anuj

go on

If this is related to login activity. Better send PR to fork of @danielpassos

@pg301

In activity_login.xml you need to replace
android:src="@drawable/hawkular_logo"
with app:srcCompat="@drawable/hawkular_logo".

The error is because we are using vector drawables instead of conventional PNG files.
Why don't you check the whole project for this type of errors.

The same error can be found in

  1. fragment_trigger_detail.xml - Line 37
pg301 commented

@free4murad Thanks for the suggestion. I knew the error, I was just scanning the layouts for similar errors. @garg-anuj since this is not connected to the login acitvity, I will send a PR here only?

@pg301
Send one PR to @danielpassos branch and one to the main repo.
In my opinion that will be a better think to do.
But confirm with @garg-anuj before you proceed.