convert underscore to dash implicitely in _clean_dict may introduce in un-expected labels

Question

convert underscore to dash implicitely in _clean_dict may introduce in un-expected labels

Closed this issue 3 years ago · 5 comments

Hi @haxsaw
The replacement in https://github.com/haxsaw/hikaru/blob/main/hikaru/generate.py#L84 may implicitely convert a custom label my_app into my-app, which is not needed in most scenarios. Is this a designed feature or a bug?

Answer 1 · 2021-11-06T18:29:35.000Z

Nuts. Yeah, this was to solve a particular problem, but I didn't think it through for all cases. I'll come up with a fix.

Answer 2 · 2021-11-09T05:48:53.000Z

this was to solve a particular problem

Would you mind to share some details of the problem?

Answer 3 · 2021-11-09T11:36:37.000Z

@haxsaw we try to fix this issue, plz help us with it and review this pr #24

Answer 4 · 2021-11-20T19:39:18.000Z

I hope you saw the new release that has a patch for your issue. Let me know if that solves it.

Answer 5 · 2021-12-14T06:38:35.000Z

Hi @haxsaw sorry for the late responding. Since we are still using version 0.5.1b0, and upgrading to the latest would cause a lot of breaks, I cant test your fix in production, and work around this issue by using label names with dashs instead of with underlines. Howeveer, as what I saw in unit tests in other projects, I believe this fix works in a lot of scenarios, so feel free to close this issue.