haydenwoodhead/burner.kiwi

Prometheus metrics

Closed this issue · 3 comments

krakazyabra commented

Hi! What was the reason to remove prom metrics? even if kiwi runs outside of k8s, metrics are bro :) may be there is another kind of monitoring inside? I took a look at the code but saw nothing regarding monitoring.

P.S. can kiwi run in cluster-mode?

haydenwoodhead commented

I removed prometheus metrics because I didn’t like the way I had implemented them. The current approach I would prefer would be to log these metrics. Are there any specific metrics you wish burner.kiwi had?

krakazyabra commented

Hi!
At first - standard go metrics, processes, gc etc
About mail - currently active mail boxes, message size, some per domain statistics (like how many mailboxes were created per each domain, how many were deleted), accepted/rejected mails, rejected by blacklist rule

that's all that came to mind.

haydenwoodhead commented

I agree that these would be useful. I would happily take a pr that adds these metrics. However, it is not something I have the bandwidth to do at this point.