[TRACKING ISSUE] Disallow different types of generic records in GenericRecordBuilder.setGenericRecord API-1773
hz-devops-test opened this issue · 1 comments
hz-devops-test commented
The tracking issue for the Java side PR.
See hazelcast/hazelcast#23522 for details.
Right now, GenericRecordBuilder.setGenericRecord does not throw if the value is not of the same type of generic record. (compact for compact, portable for portable)
We instead throw a cast exception while trying to do toData. We should do it during the setter.
Breaking changes (list specific methods/types/messages):
- If some users were misusing the API, they may be affected
Checklist:
- Labels (
Team:
,Type:
,Source:
,Module:
) and Milestone set - Label
Add to Release Notes
orNot Release Notes content
set - Request reviewers if possible
- Send backports/forwardports if fix needs to be applied to past/future releases
- New public APIs have
@Nonnull/@Nullable
annotations - New public APIs have
@since
tags in Javadoc
I don't think we need backports for this change.
mdumandag commented
not applicable as we don't have generic records yet. we will implement it with this functionality from the start