heartcombo/mail_form

ORM example should include MailForm::Shim

sporkd opened this issue · 4 comments

sporkd commented

Hello. I couldn't get mail_form to work with my ActiveRecord object until I also included MailForm::Shim. Otherwise it still sends the email, but none of the model attributes get printed (only the appends).

So in the README needs:

class User < ActiveRecord::Base
  include MailForm::Delivery
  include MailForm::Shim

instead of just:

class User < ActiveRecord::Base
    include MailForm::Delivery

Peter

josevalim commented

You should bot need the shim. This is rather a bug that can be fixed by moving the required code from shim to base!

sporkd commented

Ah good. It didn't seem too elegant to include a shim module. But it just worked so well I figured it must be the way it was intended ;)

sporkd commented

Small correction... I believe the shim code needs to move to delivery and not base. Is this what you meant?

Thanks