hebcal/hebcal-es6

Set options.hour12 to true still returns the 24h format

Closed this issue · 6 comments

meyer59 commented

Hi
The options.hour12 set to true seems to always return the 24h format in the generated strings (like Molad infos in the Mevarhim Shabbat object). Even if i force the local the string is in 24h format.
Is there something specific to do to have the 12h format in the result strings ?
Thank you

mjradwin commented

Thanks for the bug report. We will investigate and get back to you

  • 👍1
mjradwin commented

Partially fixed (for Candle lighting and Havdalah) in v5.0.7.

Not yet fixed for the Molad memo in the Mevarhim Shabbat object

meyer59 commented

Thanks a lot. I appreciate you work here

meyer59 commented

Hello @mjradwin
Did you have some time to check for the Molad memo ?

mjradwin commented

Not, yet, it's not an easy fix.

For now, you can work around the issue by setting options.molad=true and options.shabbatMevarchim=false. You'll get the Molad announcement in the event.render() instead of the event.memo, but it will properly respect the hour12 setting.

mjradwin commented

Fixed in 5.1.0