hecrj/html-parser

expose Parser?

brandly opened this issue · 6 comments

brandly commented

hey!

as mentioned here, i wrote a DOT parser. if you look at the language spec, an ID in DOT can be arbitrary HTML, allowing for cool graph renderings like these.

i'm under the impression that this package is the best elm 0.19 HTML parser, so i'd like to use it! if i were to use it, i think i need this node definition which isn't exposed. ideally, i'd integrate it into this id definition.

is it unusual for parsers to expose the actual Parser? is there a way for me to leverage run? i don't know much about these things 😅

thanks for your time

hecrj commented

You are right! I think it would be nice to expose node so other people can build their own parsers on top of it using elm/parser!

My only worry is exposing the elm/parser dependency directly. But given that it is an official elm package I do not think it is a problem (and run is exposing it indirectly already).

  • 👍1
brandly commented

wow! thanks for responding so quickly. i'll grab the latest version and try to get it integrated ✌️

  • 👍1
hecrj commented

Glad to help! Let me know if you have any issues! :)

brandly commented

looks like it's working great!

i'm going to try a bunch of examples from this gallery and make sure everything parses, but i'm under the impression that it can thoroughly parse DOT now.

thanks again!

  • 👍1
brandly commented

hey 😄

i noticed you have Travis CI working nicely on this repo. any idea what i'm doing wrong here? https://travis-ci.org/brandly/elm-dot-lang/builds/499480568

hecrj commented

This seems relevant: https://travis-ci.community/t/elm-test-fails-with-no-output-received-from-elm-make-when-searching-for-indirect-dependencies/2347

Try untracking your package.json and package-lock.json files and add those to .gitignore.