Change asciinema embedding method
Closed this issue · 5 comments
Description
Asciinema used embed-iframe URLs previously. They dropped suppport for them and now the only way for embedding a video is with a custom js script from them.
Additional context
We possibly could re-use our GitHub Gist strategy for this.
Additional info: he refers to the gist strategy BEFORE gist provided an embeddable URL.
We used an iframe in which we injected a basic html structure that loaded the script url.
I would like to NOT do that again because we have NO cors protection while doing this. Therefore a bug in asciinema could lead to arbitrary code execution that could leak into the renderer.
I propose that we either remove asciinema or deploy a helper page on GH pages or vercel.
In that case, I'd vote for dropping asciinema.
me too.
Drop it, then