Better debug logging - Use rich.logging
hedyhli opened this issue ยท 4 comments
hedyhli commented
Description
Currently we are using the python print function to print debug info when users use --debug
, it would be better practice to use a logger (rich.logging) to log debug information, as well as requests debug info
how do you think should it be implemented? (If possible)
- Update
debug_requests_on
in search.py to use rich logger - Update debug print lines in search.py To use the logger
- Update
test_cli_debug
In CLI tests if needed
ineelshah commented
What's the status of this?
hedyhli commented
feel free to pick it if you like ๐
ineelshah commented
I am going to try helping with it.
ineelshah commented
Hi @hedythedev .
Check it out. Hopefully solves it.
Thanks for letting me solve it.