heinrich5991/libtw2

gamenet: invalidid -> invalid id

Closed this issue · 4 comments

ChillerDragon commented

Drunk teeworlds devs thought invalidid is one word. Can we fix that in libtw2?

libtw2/gamenet/generate/spec/teeworlds-0.7.5.json

Line 84 in f3c8840

{"value": 1, "name": ["spec", "invalidid"]},

heinrich5991 commented

Since that is generated, it should probably be fixed in upstream instead. Any changes there will be reflected here. Upstream is obviously unresponsive though.

https://github.com/teeworlds/teeworlds/blob/a1911c8f7d8458fb4076ef8e7651e8ef5e91ab3e/datasrc/network.py#L15C45-L15C59

heinrich5991 commented

@ChillerDragon Could you open an upstream PR?

ChillerDragon commented

lez go its merged upstream