Bot stops playing after heroku restarts it

[thesn10]

Describe the problem
Bot stops playing after heroku executes a sceduled restart once a day. You have to restart the bot manually again to make it play.

Have you followed all the instructions?
yes
Tried updating the dependencies?
yes

Bot version
newest. but this issue applies to (almost) all versions (i have this issue for like 6-12months)

[infinitepower18]

If Heroku restarts the bot while it's in the voice channel, the only solution is to disconnect and reconnect the bot to the voice channel. Unfortunately this is a Discord issue and the same thing happens if I run the bot on my own PC using the official instructions.

Since the official devs don't really support Heroku there isn't really much that can be done about it. You will have to keep the bot out of the voice channel when you're not using it or let your server members know that if this happens, to use the disconnect command and then summon the bot again.

[infinitepower18]

Gonna pin this as it may be a common thing people will open an issue for

[thesn10]

Well then it might be possible to make the musicbot disconnect and reconnect automatically if it is in a voice channel on startup. Shouldnt take too long to fix, im gonna look into it.

[infinitepower18]

Well then it might be possible to make the musicbot disconnect and reconnect automatically if it is in a voice channel on startup. Shouldnt take too long to fix, im gonna look into it.

Feel free to make a pull request if you manage to fix it 🙂

[thesn10]

Look at line 425 and 424 in this method:

rhinobot_heroku/musicbot/bot.py

Lines 414 to 439 in c93de45

	async def get_player(self, channel, create=False, *, deserialize=False) -> MusicPlayer:
	guild = channel.guild
	async with self.aiolocks[_func_() + ':' + str(guild.id)]:
	if deserialize:
	voice_client = await self.get_voice_client(channel)
	player = await self.deserialize_queue(guild, voice_client)
	if player:
	log.debug("Created player via deserialization for guild %s with %s entries", guild.id, len(player.playlist))
	# Since deserializing only happens when the bot starts, I should never need to reconnect
	return self._init_player(player, guild=guild)
	if guild.id not in self.players:
	if not create:
	raise exceptions.CommandError(
	'The bot is not in a voice channel. '
	'Use %ssummon to summon it to your voice channel.' % self.config.command_prefix)
	voice_client = await self.get_voice_client(channel)
	playlist = Playlist(self)
	player = MusicPlayer(self, voice_client, playlist)
	self._init_player(player, guild=guild)
	return self.players[guild.id]

Im not very familiar with the code but commenting out line 425 will probably fix the issue. If i want to test my assumtion i would have to setup a whole new bot so if you have a bot, can you test if it works? 😄

[infinitepower18]

Look at line 425 and 424 in this method:

rhinobot_heroku/musicbot/bot.py

Lines 414 to 439 in c93de45

	async def get_player(self, channel, create=False, *, deserialize=False) -> MusicPlayer:
	guild = channel.guild
	async with self.aiolocks[_func_() + ':' + str(guild.id)]:
	if deserialize:
	voice_client = await self.get_voice_client(channel)
	player = await self.deserialize_queue(guild, voice_client)
	if player:
	log.debug("Created player via deserialization for guild %s with %s entries", guild.id, len(player.playlist))
	# Since deserializing only happens when the bot starts, I should never need to reconnect
	return self._init_player(player, guild=guild)
	if guild.id not in self.players:
	if not create:
	raise exceptions.CommandError(
	'The bot is not in a voice channel. '
	'Use %ssummon to summon it to your voice channel.' % self.config.command_prefix)
	voice_client = await self.get_voice_client(channel)
	playlist = Playlist(self)
	player = MusicPlayer(self, voice_client, playlist)
	self._init_player(player, guild=guild)
	return self.players[guild.id]

Im not very familiar with the code but commenting out line 425 will probably fix the issue. If i want to test my assumtion i would have to setup a whole new bot so if you have a bot, can you test if it works? 😄

Will test it tomorrow.

[infinitepower18]

@Sngmng nope doesn't work

[thesn10]

I've found the solution 😄 . Gonna make a PR soon

[infinitepower18]

Thanks a lot! I merged your PR.