hellofresh/health-go

add support for optionally opt-in system metrics

grzn opened this issue · 2 comments

grzn commented
add support for optionally opt-in system metrics
lucasmdrs commented

Hi @grzn 👋

Could you please elaborate a bit more about this issue/request ?

grzn commented

Hi @lucasmdrs

Yes.
Today every call to the health handler internally makes a call to newSystemMetrics in order to return runtime info in the response.

What I'm asking for is to make this optional.
Kubelet doesn't parse the http response so it does not care about the number of gorouting and memory usage so we're spending CPU on this for no reason.

It'll be great if this was optional, e.g. WithSystemInfo()

  • 👍1