helm/chart-testing

0 exit code when a chart can't be processed

pmichna opened this issue · 2 comments

pmichna commented

Is this a request for help?:
No.

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT.

Version of Helm and Kubernetes:
helm version - 3.1.2
kubectl version - 1.18
ct version - 3.0.0

What happened:
When a values file in ci/ renders problems, ct lint prints the problem in the output but exits successfully (exit code 0).

Example log:

Linting chart with values file 'foo/bar/ci/test-values.yaml'...

==> Linting foo/bar
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
engine.go:159: [INFO] Missing required value: test
engine.go:159: [INFO] Missing required value: test

What you expected to happen:
ct lint should have a non zero exit code.

How to reproduce it (as minimally and precisely as possible):

  1. Create a chart with a template that requires some value (e.g foo: "{{ required "foo" $.Values.foo }}-bar")
  2. Create ci/test-values.yaml without the required value.
  3. Run ct lint.

Anything else we need to know:
ct lint 2.3.3 returned non-zero code in the described scenario. 3.0.0 does not return non-zero exit code.

github-actions commented

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions commented

This issue was closed because it has been stalled for 5 days with no activity.