helm/chart-testing

--excluded-charts does not exclude charts when set with --charts

OlivierDupre opened this issue · 4 comments

OlivierDupre commented

Version of Helm and Kubernetes:
helm version

version.BuildInfo{Version:"v3.9.0", GitCommit:"7ceeda6c585217a19a1131663d8cd1f7d641b2a7", GitTreeState:"clean", GoVersion:"go1.18.2"}

kubectl version (many different versions from 1.21 and above)

Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:17:11Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.9", GitCommit:"3396beebcd97ed3b01f57127fba1b8565b311acb", GitTreeState:"clean", BuildDate:"2022-06-04T17:58:54Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

ct version

Version:         3.6.0
Git commit:      49167c48fd3180c183290f5be178f7aa28ff1c49
Date:            2022-05-27
License:         Apache 2.0

What happened:
I'm running ct lint with both the --charts and --excluded-charts options set. The charts excluded are tested while I was expecting them not to be.

How to reproduce it (as minimally and precisely as possible):

helm create test
cd test
sed -e 's/apiVersion: /apiVersion: {{ $foo }}/g' -i charts/templates/deployment.yaml
ct lint --validate-maintainers=false --excluded-charts=./charts/templates/deployment.yaml,./templates/deployment.yaml,deployment.yaml,templates/ --charts ./charts

Anything else we need to know:

Validation success! 👍
==> Linting ./charts
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: parse error at (test/templates/deployment.yaml:1): undefined variable "$foo"

Error: 1 chart(s) linted, 1 chart(s) failed
------------------------------------------------------------------------------------------------------------------------
 ✖︎ test => (version: "0.1.0", path: "./charts") > Error waiting for process: exit status 1
------------------------------------------------------------------------------------------------------------------------
Error: Error linting charts: Error processing charts
Error linting charts: Error processing charts

I'm expecting here nothing after the Validation success! 👍 message.

saimanoj90 commented

Any updates??

github-actions commented

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions commented

This issue was closed because it has been stalled for 5 days with no activity.

matt-matt-tmatt commented

this is still an issue

/reopen